Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Versionless Support #1827

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Adding Versionless Support #1827

merged 5 commits into from
Sep 12, 2024

Conversation

cbridgha
Copy link
Member

@cbridgha cbridgha commented Sep 5, 2024 •
edited by cherylking
Loading

I'm now passing <platform> elements along with <feature> elements while calculating which parameters to pass the Install Map

cherylking
cherylking reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the maven.yaml to reference your ci.common PR branch so the builds can pass and the tests run.

liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/InstallFeatureSupport.java Outdated Show resolved Hide resolved
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java Outdated Show resolved Hide resolved
@cherylking
Update maven.yml
3cfe026 
Removed temp change pointing to common branch.
@cherylking cherylking merged commit 85242ee into OpenLiberty:main Sep 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbridgha @cherylking