Improve binary scanner compatibility test for new versions #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ycle. Signed-off-by: Paul Gooderham <[email protected]>
…ne and this test is not run as part of the IT bucket. Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
TrevCraw
reviewed
Nov 29, 2023
liberty-maven-plugin/src/it/binary-scanner-it/run-binary-scanner-it
Outdated
Show resolved
Hide resolved
liberty-maven-plugin/src/it/binary-scanner-it/resources/basic-dev-project10/pom.xml
Show resolved
Hide resolved
…the instructions. Signed-off-by: Paul Gooderham <[email protected]>
TrevCraw
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You do need to read the comments at the top of the script to execute the tests properly so I changed the output of the script to point this out to a new person. It also prints the version of the LMP in use.
Also, I ran these tests on a new machine and they did not work. I think they work on my current machine because I've run the full IT in the past. I updated the POM to run on a new machine.