Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1572 - Add target/classes to loose app definition for newer "exploded" loose app format #1714

Merged
merged 13 commits into from
Aug 18, 2023

Conversation

scottkurz
Copy link
Member

@scottkurz scottkurz commented Aug 9, 2023

This fixes the following issues:

  1. target/classes not in loose app - Fixes Exploded loose app format doesn't include separate 'target/classes' entry; doesn't update app using mvn compile outside of all-in-one goals #1572 (this is the original issue there) - This means I can't use the format in liberty:run, do a compile (in mvn or IDE), and get an update
    • In ci.common co-req - now we don't need to do updateLooseApp on compile... which did a war:exploded or redeploy if exploded format changed. To me it's about fewer moving parts than perf. per se
  2. Detect update and apply filtering for filtered resource in the non-exploded case in DevMojo#resourceModifiedOrCreated
  3. maven-war-plugin - Default outdatedCheckPath to "/" for 3.3.2 and "WEB-INF" for 3.3.1. Rewrite the warning to recommend 3.3.2 (might as well keep it simple)
  4. Add full parms for exploded mojo
  5. Do a redeploy of the app if the war:exploded config has changed
  6. Issue warning if POM is changed to add new resources/webResources dir that will not be monitored.
  7. Fixed handling of the corner case, maybe a bit weird, if there was config for both <filteringDeploymentDescriptors>true</filteringDeploymentDescriptors> with WAR source dir also configured as resource
                       <webResources> 
                         <resource> 
                           <directory>src/main/webapp</directory> 
                           <filtering>true</filtering> 
                         </resource>

@scottkurz scottkurz changed the title Fix 1572 Fix 1572 - Add target/classes to loose app definition for newer "exploded" loose app format Aug 10, 2023
@scottkurz scottkurz force-pushed the 1572-fix branch 2 times, most recently from 0368efa to f605c77 Compare August 11, 2023 16:27
@scottkurz scottkurz marked this pull request as ready for review August 15, 2023 16:51
@scottkurz scottkurz force-pushed the 1572-fix branch 6 times, most recently from e29946e to 463f294 Compare August 17, 2023 15:35
Signed-off-by: Scott Kurz <[email protected]>
…gin but delegate to user config if present

Signed-off-by: Scott Kurz <[email protected]>
…hile only writing non-filtered directories into loose WAR XML

Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
@scottkurz scottkurz force-pushed the 1572-fix branch 2 times, most recently from 1005d05 to 278e56d Compare August 18, 2023 02:51
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question.

@scottkurz scottkurz merged commit e1737c9 into OpenLiberty:main Aug 18, 2023
0 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants