-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1572 - Add target/classes to loose app definition for newer "exploded" loose app format #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherylking
approved these changes
Aug 9, 2023
scottkurz
changed the title
Fix 1572
Fix 1572 - Add target/classes to loose app definition for newer "exploded" loose app format
Aug 10, 2023
scottkurz
force-pushed
the
1572-fix
branch
2 times, most recently
from
August 11, 2023 16:27
0368efa
to
f605c77
Compare
scottkurz
force-pushed
the
1572-fix
branch
6 times, most recently
from
August 17, 2023 15:35
e29946e
to
463f294
Compare
Signed-off-by: Scott Kurz <[email protected]>
…ates in non-exploded case Signed-off-by: Scott Kurz <[email protected]>
…gin but delegate to user config if present Signed-off-by: Scott Kurz <[email protected]>
…hile only writing non-filtered directories into loose WAR XML Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
scottkurz
force-pushed
the
1572-fix
branch
2 times, most recently
from
August 18, 2023 02:51
1005d05
to
278e56d
Compare
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
cherylking
reviewed
Aug 18, 2023
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Show resolved
Hide resolved
cherylking
reviewed
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one question.
Signed-off-by: Scott Kurz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issues:
mvn compile
outside of all-in-one goals #1572 (this is the original issue there) - This means I can't use the format in liberty:run, do a compile (in mvn or IDE), and get an update<filteringDeploymentDescriptors>true</filteringDeploymentDescriptors>
with WAR source dir also configured as resource