Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] testing whether integration-tests as module works for plugins #1708

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Jul 20, 2023

Skip "default" ITs using:

mvnd clean verify  -DruntimeVersion=23.0.0.6 -Druntime=ol -Ponline-its -DskipPluginIts=true

Odd, but clean is needed b/c of the duplicate plugin descriptor.

@bmarwell bmarwell force-pushed the integration_test_as_module branch 2 times, most recently from 95b923d to 50f1c30 Compare July 20, 2023 18:43
[WIP] remove extension from IT, allow skipping main ITs
@scottkurz
Copy link
Member

I like the idea of bypassing the invoker:run execution (but still using invoker:install to run against the just-built-plugin). It seems like there's some work ahead though. I found a gotcha even in the LibertySettingsDirectoryTest in config-directory-it. Even though you're trying to bypass running with the invoker plugin the test Java itself is making an invoker call ! I think I fixed or bypassed it here 84a5a10 but maybe it shows there's a good amount of porting work potentially to take this to completion.

I like the fact that we'd no longer rely on <version>@pom.version@</version> which is unresolvable pre-substitution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants