Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn empty feature #1683

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Warn empty feature #1683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
409677f
Issue warning for empty feature and remove from collection
cherylking Jun 5, 2023
c2a4043
Change version to 3.8.1-SNAPSHOT
cherylking Jun 5, 2023
62d23e5
Remove yaml change for common branch
cherylking Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion liberty-maven-app-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>io.openliberty.tools</groupId>
<artifactId>liberty-maven</artifactId>
<version>3.9-SNAPSHOT</version>
<version>3.8.1-SNAPSHOT</version>
</parent>

<artifactId>liberty-maven-app-parent</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions liberty-maven-plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>io.openliberty.tools</groupId>
<artifactId>liberty-maven</artifactId>
<version>3.9-SNAPSHOT</version>
<version>3.8.1-SNAPSHOT</version>
</parent>

<artifactId>liberty-maven-plugin</artifactId>
Expand Down Expand Up @@ -66,7 +66,7 @@
<dependency>
<groupId>io.openliberty.tools</groupId>
<artifactId>ci.common</artifactId>
<version>1.8.24</version>
<version>1.8.25-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.twdata.maven</groupId>
Expand Down
2 changes: 1 addition & 1 deletion liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/InstallFeatureSupport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ else if (util == null && !noFeaturesSection) {
else {
Set<String> dependencyFeatures = getDependencyFeatures();
Set<String> serverFeatures = serverDirectory.exists() ? util.getServerFeatures(serverDirectory, getLibertyDirectoryPropertyFiles()) : null;
return InstallFeatureUtil.combineToSet(pluginListedFeatures, dependencyFeatures, serverFeatures);
return util.combineToSet(pluginListedFeatures, dependencyFeatures, serverFeatures);

}
}
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<groupId>io.openliberty.tools</groupId>
<artifactId>liberty-maven</artifactId>
<version>3.9-SNAPSHOT</version>
<version>3.8.1-SNAPSHOT</version>
<packaging>pom</packaging>
<name>Liberty Tools for Maven</name>
<description>
Expand Down