Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new skip install feature flag for dev mode #1672

Merged
merged 14 commits into from
Aug 21, 2023

Conversation

cherylking
Copy link
Member

Fixes #1646

Requires OpenLiberty/ci.common#398

Need to have a similar PR in ci.gradle as well.

Copy link
Member

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the DevSkipInstallFeatureTest logic is interesting in that it shows a corner case where you never install the features.

The flow does a Liberty install and then later starts dev mode with "-DskipInstallFeature=true" pointing back to the earlier Liberty install, and confirms we don't install the features.

So it shows it is possible to use this parm in a "bad" way and never get the features installed. You could also do a liberty:create and then "liberty:dev -DskipInstallFeature=true" and also never install the features.

That all said, maybe a more straightforward adaptation of this test would be to do the install feature back when we install Liberty and look for the same log messages:

                <configuration>
                    <serverXmlFile>${project.basedir}/resources/basic-dev-project/src/main/liberty/config/server.xml</serverXmlFile>
                    ...
                </configuration>
                <executions>
                    <execution>
                        <id>install-liberty-server</id>
                        <phase>compile</phase>
                        <goals>
                            <goal>create</goal>
                            <goal>install-feature</goal>
                        </goals>
                    </execution>
                </executions>

Copy link
Member

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making the changes.

.github/workflows/maven.yml Outdated Show resolved Hide resolved
@cherylking cherylking merged commit 6985001 into OpenLiberty:main Aug 21, 2023
0 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to skip feature installation
2 participants