Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve variables in app location and fix app configuration validation logic #1655

Merged
merged 12 commits into from
Apr 4, 2023
Merged

Resolve variables in app location and fix app configuration validation logic #1655

merged 12 commits into from
Apr 4, 2023

Conversation

cherylking
Copy link
Member

Fixes #1145 and requires OpenLiberty/ci.common#394.

@cherylking cherylking force-pushed the handleVarsInAppLocation branch 3 times, most recently from 030c362 to bcbfb2f Compare March 30, 2023 19:58
@cherylking cherylking mentioned this pull request Mar 31, 2023
Merged
scottkurz
scottkurz approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this seems to resolve my original recreate scenario on Windows.

@cherylking cherylking merged commit e66ab39 into OpenLiberty:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottkurz scottkurz scottkurz approved these changes

@mattbsox mattbsox mattbsox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cherylking @scottkurz @mattbsox