Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
cherylking committed Feb 21, 2024
1 parent f0d36c4 commit 5975d42
Showing 1 changed file with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -997,9 +997,7 @@ public boolean recompileBuildFile(File buildFile, Set<String> compileArtifactPat

// Monitoring liberty properties in the pom.xml
if (hasInstallationPropChanged(project, backupProject)) {
// Note that a change in some config values requires a 'clean' because the install location is the same, but the
// artifact that gets installed would be different. This can happen when using 'libertyRuntime' for example and
// only changing the 'version'.
// Note that a change in installation config values requires a restart of dev mode.
reinstallLiberty = true;
getLog().error("A change in Liberty runtime installation configuration requires a restart of dev mode. Stopping dev mode.");
}
Expand All @@ -1022,10 +1020,7 @@ public boolean recompileBuildFile(File buildFile, Set<String> compileArtifactPat
restartServer = true;
}
if (hasInstallationConfigChanged(config, oldConfig)) {
// Note that a change in some config values requires a 'clean' because the install location is the same, but the
// artifact that gets installed would be different. This can happen when using 'runtimeArtifact' for example and
// only changing the 'version'.
//throw new PluginExecutionException("A change in Liberty runtime installation configuration requires a 'clean'. After running the 'clean' goal, please run the 'dev' goal again for the change to take effect.");
// Note that a change in installation config values requires a restart of dev mode.
reinstallLiberty = true;
getLog().error("A change in Liberty runtime installation configuration requires a restart of dev mode. Stopping dev mode.");
}
Expand Down

0 comments on commit 5975d42

Please sign in to comment.