Add installDir project property detection #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbsox
approved these changes
Nov 18, 2021
cherylking
requested changes
Nov 18, 2021
src/test/groovy/io/openliberty/tools/gradle/InstallLiberty_installDir_missing_wlp_Test.groovy
Show resolved
Hide resolved
cherylking
approved these changes
Nov 18, 2021
installDir sentence
cherylking
reviewed
Nov 19, 2021
docs/libertyExtensions.md
Outdated
| @@ -14,7 +14,7 @@ The [deploy](deploy.md), [undeploy](undeploy.md), [libertyPackage](libertyPackag | |||
| | --------- | ---- | ----- | ----------- | ---------| | |||
| | baseDir | String | 3.0 | The base installation directory. The actual installation directory of WebSphere Liberty server will be `${baseDir}/wlp`. The default value is `${project.buildDir}`. This was moved from the properties in the `install` block in version 3.0.| No | | |||
| | cacheDir | String | 3.0 | The directory used for caching downloaded files such as the license or `.jar` files. The default value is `${java.io.tmpdir}/wlp-cache`. This was moved from the properties in the `install` block in version 3.0.| No | | |||
| | installDir | String | 1.0 | Path to the WebSphere Liberty server installation `wlp` directory. To use a pre-installed version of Liberty, set this property to the path of the Liberty `wlp` directory, including `wlp` in the path. | No | | |||
| | installDir | String | 1.0 | Path to the WebSphere Liberty server installation `wlp` directory. To use a pre-installed version of Liberty, set this property to the path of the Liberty `wlp` directory, including `wlp` in the path. <br /> <br /> Additionally, `installDir` can be specified in the `gradle.properties` file or from the command line using `-Pliberty.installDir={wlp}`. | No | | |||
There was a problem hiding this comment.
I don't think I would put {wlp} in the example, and let's remove the break.
There was a problem hiding this comment.
Also, installLiberty.md might be a good place to show an example usage of the installDir property. That is where the runtime properties for specifying groupId, artifactId and version for the Liberty runtime are discussed in more detail.
cherylking
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #629