Change generated file name to generated-features.xml #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Kodama <[email protected]>
7 tasks
turkeylurkey
approved these changes
Nov 10, 2021
cherylking
pushed a commit
that referenced
this pull request
Dec 15, 2021
* Add Generate Features prototype and implement the necessary interfaces. Signed-off-by: Paul Gooderham <[email protected]> * Add the generateFeatures command line and build file option. Signed-off-by: Paul Gooderham <[email protected]> * Add comment to existing server.xml and scan gradle classes dirs. Signed-off-by: Paul Gooderham <[email protected]> * Code cleanup. Signed-off-by: Paul Gooderham <[email protected]> * Make generateFeatures option command line only. Clean up streams code. Signed-off-by: Paul Gooderham <[email protected]> * Allow generateFeatures=false * Add classFile option to GenerateFeaturesTask (#640) Signed-off-by: Kathryn Kodama <[email protected]> * Get binary scanner jar from connected repos * Fix name of API method. Signed-off-by: Paul Gooderham <[email protected]> * Use gradle convention for latest release version * Update message * Change generated file name to generated-features.xml (#644) Signed-off-by: Kathryn Kodama <[email protected]> * Fix NPE and remove getAllServerFeatures * Fix IO error when server is not yet setup. Signed-off-by: Paul Gooderham <[email protected]> * Quick fix Signed-off-by: Paul Gooderham <[email protected]> * Remove binary scanner jar parameter * Handle optimize and non-optimize cases * Add a system where the binary scanner handler detects an error generated by the scanner and calls it again with fewer restrictions in order to generate a list of suggested features that should work. This error and suggested solution is then displayed to the user. * Improved error reporting after code review. Signed-off-by: Paul Gooderham <[email protected]> * After writing server.xml ensure <server> element is on a new line. Signed-off-by: Paul Gooderham <[email protected]> * Move the xml document rewrite code into ci.common. Signed-off-by: Paul Gooderham <[email protected]> * Remove unused import. Signed-off-by: Paul Gooderham <[email protected]> * Use the binary scanner support in ci.common. Signed-off-by: Paul Gooderham <[email protected]> * Remove unused imports and class variable. Signed-off-by: Paul Gooderham <[email protected]> * Allow info messages to appear in output by default and without setting log level to Info. Signed-off-by: Paul Gooderham <[email protected]> * Get existing features for feature gen from the source config dir (#661) * Get existing features for feature gen from the source config dir Signed-off-by: Kathryn Kodama <[email protected]> * Call generate features on dev mode startup and restart Signed-off-by: Kathryn Kodama <[email protected]> * Simplify getServerFeatureUtil method Signed-off-by: Kathryn Kodama <[email protected]> * Update to use latest snapshot from ci.common Signed-off-by: Kathryn Kodama <[email protected]> * Add binary scanner sonatype repo to dev test Signed-off-by: Kathryn Kodama <[email protected]> * Update sonatype repo link in dev tests Signed-off-by: Kathryn Kodama <[email protected]> * Diable feature generation in dev tests Signed-off-by: Kathryn Kodama <[email protected]> * Added optimize parameter for generating features * Added optimize parameter to generateFeatures task * Feature generation, create generated xml file with empty feature list (#664) * When no features left to generate create generated xml file with empty feature list Signed-off-by: Kathryn Kodama <[email protected]> * Improve comment in generated-features.xml Signed-off-by: Kathryn Kodama <[email protected]> * Improve formatting for comments Signed-off-by: Kathryn Kodama <[email protected]> * Allow optimize to be passed in as a String parameter * Use binary scanner Maven coordinates promoted by the scanner team. Signed-off-by: Paul Gooderham <[email protected]> * Fix compileJava call in recompileBuildFile * Put snapshot repo on project level for dev tests Signed-off-by: Kathryn Kodama <[email protected]> * Updated debug statements * Use new method downloadBuildArtifact() to search buildscript portion of build.gradle Signed-off-by: Paul Gooderham <[email protected]> * Exception handling for generateFeatures (#672) * Exception handling for generateFeatures Signed-off-by: Kathryn Kodama <[email protected]> * Updated generateFeatures error message and generated-features.xml comment Signed-off-by: Kathryn Kodama <[email protected]> * Remove unnecessary imports and adjust copyright header Signed-off-by: Kathryn Kodama <[email protected]> * Update dev test project build.gradle Signed-off-by: Kathryn Kodama <[email protected]> * Improve comment for default generateFeatures behaviour Signed-off-by: Kathryn Kodama <[email protected]> * Improve exception handling message when generate features fails (#675) * Improve exception handling message when generate features fails Signed-off-by: Kathryn Kodama <[email protected]> * Add return boolean for libertyGenerateFeatures method Signed-off-by: Kathryn Kodama <[email protected]> * Add missing return statement for createNewInstallFeatureUtil (#678) Signed-off-by: Kathryn Kodama <[email protected]> Co-authored-by: Paul Gooderham <[email protected]> Co-authored-by: Eric Lau <[email protected]> Co-authored-by: Kathryn Kodama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kathryn Kodama [email protected]