Modify behavior for include directory to match Liberty #426

evie-lau · 2023-10-26T18:27:10Z

Follow-up to #425
Match Liberty behavior where directory has to end in File.separator

Note: Both Liberty and our test code convert Windows \ into /, so all the logic uses /

Note implemented behavior in #426 (comment)

src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java

...t/java/io/openliberty/tools/common/plugins/util/InstallFeatureUtilGetServerFeaturesTest.java

…nclude dir error message

Modify behavior for include directory to match Liberty

959f1fa

evie-lau requested a review from cherylking October 26, 2023 18:27

evie-lau commented Oct 26, 2023

View reviewed changes

src/main/java/io/openliberty/tools/common/plugins/config/ServerConfigDocument.java Outdated Show resolved Hide resolved

cherylking requested changes Oct 26, 2023

View reviewed changes

evie-lau added 3 commits October 26, 2023 16:41

Address review comments

e1820ae

Add ability to track and verify error logs in tests. Verify invalid i…

ece394f

…nclude dir error message

Make error check method non-abstract to not affect LMP/LGP

15a70c2

cherylking approved these changes Oct 27, 2023

View reviewed changes

evie-lau added 2 commits October 27, 2023 09:47

Update comment on containsErrorMessage

3d60dba

Fix test assertion

606e94d

evie-lau merged commit d5b02e9 into OpenLiberty:main Oct 27, 2023
8 checks passed

evie-lau deleted the includeDirFixes branch October 27, 2023 15:20

Provide feedback