Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable signature verification for feature install #414

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Enable signature verification for feature install #414

merged 4 commits into from
Oct 23, 2023

Conversation

jjiwooLim
Copy link
Contributor

In addition to OpenLiberty/open-liberty#17220.
FeatureUtility now verifies downloaded features from Maven Central. Enabling the same functionality for Liberty Maven Plugin's install-feature goal and Liberty Gradles Plugin's installFeature task.

@cherylking
Copy link
Member

We plan on doing a release by the end of September. Does this need to go into that? This requires changes in ci.maven and ci.gradle too right? And new tests?

@jjiwooLim jjiwooLim force-pushed the verifySig branch 3 times, most recently from f70a772 to 6e1e7b1 Compare October 6, 2023 17:37
cherylking
cherylking requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See two minor change requests. Thanks.

@cherylking cherylking merged commit d93e233 into OpenLiberty:main Oct 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjiwooLim @cherylking