Merge pull request #409 from scottkurz/fine-tune-exploded-loose-app-u…

…pdate Avoid unnecessary war:exploded calls for mere recompilation of Java c…
OpenLiberty · Aug 18, 2023 · b08c49b · b08c49b
2 parents 09c8274 + 1a4e80c
commit b08c49b
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java b/src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java
@@ -357,8 +357,9 @@ private enum FileTrackMode {
     private File configDirectory;
     private File projectDirectory;
     private File multiModuleProjectDirectory;
-    private List<File> resourceDirs;
-    private List<Path> webResourceDirs;
+    protected List<File> resourceDirs;
+    // Not all webResource dirs need to be monitored, but those for which a Maven filtering will be applied do, since they can't be added to the loose app as source
+    protected List<Path> monitoredWebResourceDirs;
     private boolean hotTests;
     private Path tempConfigPath;
     private boolean skipTests;
@@ -443,7 +444,7 @@ public DevUtil(File buildDirectory, File serverDirectory, File sourceDirectory,
             boolean skipDefaultPorts, JavaCompilerOptions compilerOptions, boolean keepTempDockerfile,
             String mavenCacheLocation, List<ProjectModule> upstreamProjects, boolean recompileDependencies,
             String packagingType, File buildFile, Map<String, List<String>> parentBuildFiles, boolean generateFeatures,
-            Set<String> compileArtifactPaths, Set<String> testArtifactPaths, List<Path> webResourceDirs) {
+            Set<String> compileArtifactPaths, Set<String> testArtifactPaths, List<Path> monitoredWebResourceDirs) {
         this.buildDirectory = buildDirectory;
         this.serverDirectory = serverDirectory;
         this.sourceDirectory = sourceDirectory;
@@ -509,7 +510,7 @@ public DevUtil(File buildDirectory, File serverDirectory, File sourceDirectory,
         this.generateFeatures = generateFeatures;
         this.compileArtifactPaths = compileArtifactPaths;
         this.testArtifactPaths = testArtifactPaths;
-        this.webResourceDirs = webResourceDirs;
+        this.monitoredWebResourceDirs = monitoredWebResourceDirs;
         this.generatedFeaturesFile = new File(configDirectory, BinaryScannerUtil.GENERATED_FEATURES_FILE_PATH);
         this.generatedFeaturesModified = false;
         if (this.generateFeatures) {
@@ -2835,7 +2836,7 @@ public void watchFiles(File outputDirectory, File testOutputDirectory, final Thr
             }
 
             HashMap<Path, Boolean> webResourceMap = new HashMap<Path, Boolean>();
-            for (Path webResourceDir : webResourceDirs) {
+            for (Path webResourceDir : monitoredWebResourceDirs) {
                 webResourceMap.put(webResourceDir, false);
                 if (Files.exists(webResourceDir)) {
                     registerAll(webResourceDir, executor);
@@ -3033,7 +3034,7 @@ public void watchFiles(File outputDirectory, File testOutputDirectory, final Thr
                 }
 
                 // Check if webResourceDirectory has been added or deleted
-                for (Path webResourceDir : webResourceDirs) {
+                for (Path webResourceDir : monitoredWebResourceDirs) {
                     if (!webResourceMap.get(webResourceDir) && Files.exists(webResourceDir)) {
                     	updateLooseApp();
                         registerAll(webResourceDir, executor);
@@ -3893,7 +3894,7 @@ private void processFileChanges(
         Path configPath = this.configDirectory.getCanonicalFile().toPath();
         Path outputPath = this.outputDirectory.getCanonicalFile().toPath();
 
-        Path directory = fileChanged.getParentFile().toPath();
+        Path directory = fileChanged.getParentFile().getCanonicalFile().toPath();
 
         // resource file check
         File resourceParent = null;
@@ -3906,7 +3907,7 @@ private void processFileChanges(
 
         // webResource file check
         Path webResourceParent = null;
-        for (Path webResourceDir : webResourceDirs) {
+        for (Path webResourceDir : monitoredWebResourceDirs) {
             if (directory.startsWith(webResourceDir)) {
                 webResourceParent = webResourceDir;
                 break;
@@ -4082,9 +4083,6 @@ private void processFileChanges(
                             }
                         }
                     }
-                    // Update the loose app in case something changed 
-                    updateLooseApp();
-
                 } else if (upstreamResourceParent != null
                         && directory.startsWith(upstreamResourceParent.getCanonicalFile().toPath())) { // resources
                     debug("Resource dir: " + upstreamResourceParent.toString());
@@ -4233,8 +4231,6 @@ private void processFileChanges(
                         triggerJavaTestRecompile = true;
                     }
                 }
-                // Update the loose app in case something changed 
-                updateLooseApp();
                 runTestThread(true, executor, numApplicationUpdatedMessages, skipUTs, false, buildFile);
             }
         } else if (fileChanged.equals(dockerfileUsed)
@@ -4998,8 +4994,6 @@ protected boolean recompileJava(Collection<File> javaFilesChanged, Set<String> a
                     // redeploy app after compilation if not loose application
                     if (!isLooseApplication()) {
                         redeployApp();
-                    } else {
-                        updateLooseApp();
                     }
                     if (projectName != null) {
                         info(projectName + " source compilation was successful.");