Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ownership to templates and ranges + Implement auth endpoints #56

Merged
merged 71 commits into from
Mar 8, 2025
Merged

Add ownership to templates and ranges + Implement auth endpoints #56

merged 71 commits into from
Mar 8, 2025

Conversation

Adamkadaban
Copy link
Member

@Adamkadaban Adamkadaban commented Feb 26, 2025 •
edited
Loading

Checklist

  • I have added a version label to my PR (e.g., patch, minor, major).
  • I have tested my changes locally and verified they work as expected.
  • I have added relevant tests to cover my changes.
  • I have made any necessary updates to the documentation.

Description

  • Add user models and schemas
  • Add cloud secret models and schemas
  • Add concept of ownership to templates and deployed ranges
  • Add login and register endpoints
  • Change all template tests to be authenticated
  • Add unit tests for login and register endpoints
  • Allow admin to read/deploy anything
  • Add endpoints for reading user info
  • Add endpoints for checking user secrets
  • Add endpoints for adding secrets to DB
  • Encrypt secrets (See Allow for user signup and secure storage of user secrets in DB #26 (comment))

Fixes:
#26
#14
#43

@Adamkadaban
fix typo. RRFC -> RFC
6ed3511
@Adamkadaban
add user secret and model
a889938
@Adamkadaban
add secret model and fix up naming in user model
8a8a48d
@Adamkadaban
add secret schema
528e054
@Adamkadaban
add crud for users
a8111ce
@Adamkadaban
add auth endpoints
0a38c42
@Adamkadaban
add template endpoints
8c0ad3d
@Adamkadaban
add range endpoint
8f6e17b
@Adamkadaban
add bcrypt and jwt requirements for auth
5231761
@Adamkadaban
add auth route to router
354e034
@Adamkadaban
make error messages for template routes more consistent with other ra…
e16035f 
…nge and template routes
@Adamkadaban
add core auth logic that will be used for all authenticated endpoints
e437d51
@Adamkadaban
add config for auth
2d98188
@Adamkadaban
popoulate and check owner for templates crud
34f953b
@Adamkadaban
add crud for users
803cf32
@Adamkadaban
fix typo in user schema
c8837f9
@Adamkadaban
add owner to template base model
3d59cef
@Adamkadaban
add user model with correct naming
7cda2f0
@Adamkadaban
fix prefix for auth route
3bb2bab
@Adamkadaban
change auth login error messages to not report if user exists or not …
0cb7d64 
…when attempting to log in
@Adamkadaban
add basic tests for auth endpoints
64376f8
@Adamkadaban
dumb solution to get all clients authorized
edf778d
@Adamkadaban
change usernames for registering between auth and template tests so t…
15f1495 
…hings dont overlap. we essentially have two blank states without having to delete templates
@Adamkadaban
add test to make sure users can only access their own templates
836aa4d
@Adamkadaban
appease mypy
8bbe67e
@Adamkadaban
make sure timezones are in UTC in the database
52dc81b
@Adamkadaban
appease ruff
7a28a3c
@Adamkadaban
format with black
5aed21a
@Adamkadaban Adamkadaban added the minor Increment the minor version when merged label Feb 26, 2025
This was referenced Mar 6, 2025
Closed
Closed
Nareshp1
Nareshp1 reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@Nareshp1 Nareshp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments I left.

Nareshp1
Nareshp1 reviewed Mar 6, 2025
View reviewed changes
@Adamkadaban Adamkadaban requested a review from Nareshp1 March 7, 2025 14:32
alexchristy
alexchristy requested changes Mar 7, 2025
View reviewed changes
@alexchristy
Copy link
Member

I also want to say awesome work getting the authentication setup for the application. The secure encryption of the secrets it really cool but also will save us so many headaches in the future.

@Adamkadaban Adamkadaban requested a review from alexchristy March 8, 2025 16:38
@Adamkadaban Adamkadaban force-pushed the adam-auth-2 branch 2 times, most recently from 978ed73 to da98a01 Compare March 8, 2025 21:29
Nareshp1
Nareshp1 approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@Nareshp1 Nareshp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexchristy
alexchristy approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@alexchristy alexchristy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here!

@Adamkadaban Adamkadaban merged commit 906a1de into main Mar 8, 2025
6 checks passed
@Adamkadaban Adamkadaban deleted the adam-auth-2 branch March 11, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nareshp1 Nareshp1 Nareshp1 approved these changes

@alexchristy alexchristy alexchristy approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adamkadaban @alexchristy @Nareshp1