Use one handler for all map_property packets #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@farrainbow What's the best way to test this? I reviewed the code and it looks good. Do I need to go to a PVP map in order to make sure this is working? |
|
Enable related config options (status_mapType, status_mapProperty) and visit different maps? PVP would be good to check since I didn't really visited one with this. |
|
I think this is good to merge; the only change I will advise is to add a message log to output the map property. This way when people start using it and just in case there are problems, their screenshots or logfiles will contain usable information. @farrainbow what do you think? |
Wariorr99
approved these changes
Jun 22, 2022
LastRoze
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move to Receive.pm and tweak unpack strings a bit.