Skip to content

Port over BashSession and tests #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xingyaoww merged 7 commits into from
Aug 24, 2025
Merged

Port over BashSession and tests #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d63e596
add how we perform tests
xingyaoww Aug 24, 2025
9c51064
port over initial implementation of tmux session
xingyaoww Aug 24, 2025
abd8085
move bash session
xingyaoww Aug 24, 2025
011f9ce
Fix execute_bash tests and improve BashSession implementation
xingyaoww Aug 24, 2025
1340fcc
use relative import for conf test
xingyaoww Aug 24, 2025
fc7c6b7
add .agent_observation field to convert it to agent obs
xingyaoww Aug 24, 2025
6d02f1f
remove logging, add self.error to agent_observation
xingyaoww Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .openhands/microagents/repo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ This project contains my tasks of completely refactor [OpenHands](https://github
- read [openhands/core/runtime/tools/str_replace_editor/impl.py](openhands/core/runtime/tools/str_replace_editor/impl.py) for tool execute_fn
- read [openhands/core/runtime/tools/str_replace_editor/definition.py](openhands/core/runtime/tools/str_replace_editor/definition.py) for how do we define a tool
- read [openhands/core/runtime/tools/str_replace_editor/__init__.py](openhands/core/runtime/tools/str_replace_editor/__init__.py) for how we define each tool module
- Check how we perform tests in .github/workflows/tests.yml
- ...
</TASK>

Expand Down
5 changes: 5 additions & 0 deletions openhands/core/runtime/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,8 @@ class ObservationBase(Schema):
"""Base schema for output observation."""

model_config = ConfigDict(extra="allow")

@property
def agent_observation(self) -> str:
"""Get the observation string to show to the agent."""
raise NotImplementedError("Subclasses must implement agent_observation")
Loading