Repository navigation
chore: remove merged PR artifacts - #5482
all-hands-bot wants to merge 2 commits into
Conversation
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
9ca131b to
fc3d222
Compare
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was posted by an AI agent (OpenHands).
Review: chore: remove merged PR artifacts
Scope: deletion-only, +0 -187 across .pr/stop-bash-evidence.md and .pr/stop-bash-evidence.py.
Verification on head fc3d222a0f40e9c3736840a35fbfcb3a13576ab6:
git diff --name-status origin/main...HEADshows the only changes are the two deletions under.pr/; no other tracked file is touched.- Both files exist on
mainand are absent on the head, so the cleanup is complete. - No code imports or references the deleted files. A repository-wide grep for
stop-bash-evidence/.pr/finds only generic.pr/references inCONTRIBUTING.mdand the skill docs, which describe the transient-artifact workflow rather than these specific files. .pr/is by design temporary and is owned by the repository's own cleanup workflow (.github/workflows/pr-artifacts.yml);CONTRIBUTING.mdand.agents/skills/custom-codereview-guide.mdboth treat.pr/artifacts as workflow-owned. Removing artifacts that leaked ontomainis exactly the intended action, so this change belongs in this repository.- All 52 check runs for the head are
completed/success(includingpre-commit,REST API (OpenAPI),test (24.x),Persisted settings, andsecurity); none are failing or still in progress.
No material findings: this is a safe, in-scope artifact cleanup with no behavior change.
✅ APPROVED
fc3d222 to
7e0edd9
Compare
7e0edd9 to
5282ff5
Compare
5282ff5 to
d1b7677
Compare
d1b7677 to
6194bb3
Compare
6194bb3 to
a682757
Compare
a682757 to
21c875c
Compare
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was posted by an AI agent (OpenHands).
Review: chore: remove merged PR artifacts
Scope: deletion-only, +0 -187 across .pr/stop-bash-evidence.md and .pr/stop-bash-evidence.py.
Head re-checked: 21c875c289acc0a9acd90a46216ddfd7503c5f02.
Finding: the PR is now a no-op against current main
- The current
maintip (39d34ec) no longer contains either deleted file:git ls-tree origin/main -- .pr/is empty andGET /contents/.pr/stop-bash-evidence.md?ref=mainreturns 404. - These exact artifacts were removed from
mainby PR #5479 (commiteeba47c, "feat(agent-server): serve a manifest-declared SVG icon for canvas extensions",.pr/stop-bash-evidence.md-75 /.pr/stop-bash-evidence.py-112), andgit merge-base --is-ancestor eeba47c origin/mainconfirms that commit is onmain. - Consequently, merging this branch would not change the
maintree: the branch isbehind_by: 6, ahead_by: 1ofmain, and its only commit deletes files thatmainhas already dropped.
This is not a defect in the change itself — the deletion is correct and in-scope (.pr/ is temporary, workflow-owned per CONTRIBUTING.md and .agents/skills/custom-codereview-guide.md, and cleaned by .github/workflows/pr-artifacts.yml). But it does mean there is nothing left for this PR to accomplish, so it can be closed rather than merged. Flagging it so a maintainer can make that call; no code change is required.
Checks
All 52 check runs for this head are completed/success (including check-pr-artifacts, pre-commit, REST API (OpenAPI), agent-server-tests, and Persisted settings); none are failing or in progress. cleanup-on-approval and cleanup-after-merge are skipped, as expected for this workflow.
No code-level findings.
✅ APPROVED
21c875c to
6a9a494
Compare
6a9a494 to
c5ed4c0
Compare
c5ed4c0 to
bdeac4c
Compare
bdeac4c to
0f934b0
Compare
0f934b0 to
70832e7
Compare
Co-authored-by: openhands <openhands@all-hands.dev>
70832e7 to
f03e8fa
Compare
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was posted by an AI agent (OpenHands).
Review: chore: remove merged PR artifacts
Scope: deletion-only, +0 -56 in .pr/validation.md.
Head re-checked: f03e8fa3cad0d7917e50c4f27c92951e78dc46b0.
Finding: the PR is a no-op against current main
- Current
maintip (250dd48) does not contain.pr/validation.md:git ls-tree origin/main -- .pr/is empty, andGET /contents/.pr/validation.md?ref=mainreturns 404. - The file was already removed from
mainby commit250dd48("fix(agent-server): omit acp/ credential dir from download-trajectory zip (#5551)",.pr/validation.md-56), andgit merge-base --is-ancestor 250dd48 origin/mainconfirms that commit is onmain. - The branch is
behind_by: 1, ahead_by: 1ofmain, and its single commit deletes a filemainhas already dropped, so merging would not change themaintree.
The deletion itself is correct and in-scope — .pr/ is temporary and workflow-owned (CONTRIBUTING.md, .agents/skills/custom-codereview-guide.md, cleaned by .github/workflows/pr-artifacts.yml) — but there is nothing left for this PR to accomplish, so it can be closed rather than merged. Flagging for a maintainer; no code change is required.
Checks
All 51 check runs for this head are completed/success; Validate PR description, cleanup-on-approval, and cleanup-after-merge are skipped as expected. No failures or in-progress runs.
No code-level findings.
✅ APPROVED
Why
Temporary
.pr/artifacts reachedmainthrough one or more merged PRs.Summary
.pr/directory frommain.How to Test
.pr/.This PR was automatically created by the PR Artifacts workflow.
🐳 Agent Server images for this PR — GHCR package, pull/run commands, and all pushed tags (click to expand)
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdkpython-node-runtimepython-node-runtimepython-node-runtimegolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:9699865-pythonRun
All tags pushed for this build
About Multi-Architecture Support
9699865-python) is a multi-arch manifest supporting both amd64 and arm649699865-python-amd64) are also available if needed