Skip to content

docs(run-eval): require maintainer approval before editing verified_models.py #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanmichelini merged 2 commits into from
Jun 3, 2026
Merged

docs(run-eval): require maintainer approval before editing verified_models.py #3479

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6914590
docs(run-eval): clarify verified_models.py should only be edited when…
openhands-agent Jun 3, 2026
faf2a82
Merge branch 'main' into openhands/update-addingmodel-verified-list-g…
juanmichelini Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/run-eval/ADDINGMODEL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,20 @@ This file (`resolve_model_config.py`) defines models available for evaluation. M
- `openhands-sdk/openhands/sdk/llm/utils/model_prompt_spec.py` - GPT models only (variant detection)
- `openhands-sdk/openhands/sdk/llm/utils/verified_models.py` - Production-ready models

> ⚠️ **When editing `verified_models.py`**: If you add a model to `VERIFIED_OPENHANDS_MODELS`,
> you **must also** add it to its provider-specific list (e.g. `VERIFIED_ANTHROPIC_MODELS`,
> `VERIFIED_GEMINI_MODELS`, `VERIFIED_MOONSHOT_MODELS`, etc.).
> If no list exists for the provider yet, create one and add it to the `VERIFIED_MODELS` dict.
> This ensures the model appears under its actual provider in the UI, not just under "openhands".
> ⛔ **Do NOT add a model to `verified_models.py` unless explicitly asked to.**
> "Verified" means the model has been validated against the OpenHands integration
> test suite **and** an OpenHands maintainer has approved it for the production UI.
> A passing integration run is *necessary but not sufficient*. New models should be
> added to `MODELS` in `resolve_model_config.py` (and `model_features.py` if
> applicable) only — leave `verified_models.py` alone until a maintainer requests it
> in the PR.
Comment thread
enyst marked this conversation as resolved.
>
> ⚠️ **When you are explicitly asked to edit `verified_models.py`**: If you add a
> model to `VERIFIED_OPENHANDS_MODELS`, you **must also** add it to its
> provider-specific list (e.g. `VERIFIED_ANTHROPIC_MODELS`, `VERIFIED_GEMINI_MODELS`,
> `VERIFIED_MOONSHOT_MODELS`, etc.). If no list exists for the provider yet, create
> one and add it to the `VERIFIED_MODELS` dict. This ensures the model appears under
> its actual provider in the UI, not just under "openhands".

## Step 1: Add to resolve_model_config.py

Expand Down
Loading