Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 2 bugs in the fastq reader: #497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for 2 bugs in the fastq reader: #497

wants to merge 1 commit into from

Commits on Jun 15, 2023

  1. Fix for 2 bugs in the fastq reader: 

    - \r\n handling may cause reading a byte past end of buffer, parser fails
- checking end-of-file condition can only be reliably done
  after a call to getLine() returns NULL. One particular case
  is that some gzip files contain empty gzip blocks at the end
  of the file, which can´t be predicted by the current eof() code
  Tested with files provided in issue OpenGene#491.

This reverts commit 0ee1b3b, "fix a regression bug of FASTQ reader"
    @wdu
    wdu committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d940c2e View commit details
    Browse the repository at this point in the history