Using Protocol.name when resolving HTTP protocol for responses #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `toString()` method on `OkHttp3.Protocol` does not return a value that can be used to resolve to enum `ProtocolVersion`. This change extracts the `name` from the Protocol and uses that instead of the whole Protocol object. Fixes OpenFeign#2427
velo
approved these changes
May 23, 2024
|
@velo, thanks for the merge. When do you expect that the next version will be released? |
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
The `toString()` method on `OkHttp3.Protocol` does not return a value that can be used to resolve to enum `ProtocolVersion`. This change extracts the `name` from the Protocol and uses that instead of the whole Protocol object. Fixes #2427 Co-authored-by: Henrik Stene <[email protected]>
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
The `toString()` method on `OkHttp3.Protocol` does not return a value that can be used to resolve to enum `ProtocolVersion`. This change extracts the `name` from the Protocol and uses that instead of the whole Protocol object. Fixes #2427 Co-authored-by: Henrik Stene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
toString()method onOkHttp3.Protocoldoes not return a value that can be used to resolve to enumProtocolVersion.This change extracts the
namefrom the Protocol and uses that instead of the whole Protocol object.Fixes #2427