Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module move and rename: spring4 -> spring #2392

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

vitalijr2
Copy link
Collaborator

Resolve #2386 and some Spring issues.

@vitalijr2 vitalijr2 requested review from velo, wplong11 and kdavisk6 April 23, 2024 08:19
@velo
Copy link
Member

velo commented Apr 23, 2024

It would be nice to also include the relocation information, at least for the next release

@vitalijr2
Copy link
Collaborator Author

I have added one-line description to CHANGELOG.md that could be re-used in next release.

@velo
Copy link
Member

velo commented Apr 23, 2024

Ow, I was thinking about this
https://maven.apache.org/guides/mini/guide-relocation.html

In short, you leave behind a strip down pom for fegin-spring4 and include distributionManagement/relocation/artifactId

@vitalijr2
Copy link
Collaborator Author

Interesting Maven feature, didn't know about it

spring4/pom.xml Outdated
<relocation>
<groupId>io.github.openfeign</groupId>
<artifactId>feign-spring</artifactId>
<version>13.3-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, changed it some seconds later :)

@velo velo merged commit dbf09e7 into OpenFeign:master Apr 25, 2024
3 checks passed
@vitalijr2 vitalijr2 deleted the rename-spring-module branch April 25, 2024 14:23
velo pushed a commit that referenced this pull request Oct 7, 2024
* Module move and rename: spring4 -> spring

* Add the description for changes of Spring(4) module

* Feign Spring: relocation information

* Feign Spring, relocation: leave only artifactId

* Update license plugin's configuration
velo pushed a commit that referenced this pull request Oct 8, 2024
* Module move and rename: spring4 -> spring

* Add the description for changes of Spring(4) module

* Feign Spring: relocation information

* Feign Spring, relocation: leave only artifactId

* Update license plugin's configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we move to next Spring?
2 participants