Allow to ignore methods on provided interface

[gromspys]

Issue: #686

Summary by CodeRabbit

• New Feature: Introduced the @FeignIgnore annotation. This allows developers to mark certain methods to be ignored during processing, enhancing control over the application's behavior.
• New Feature: Added error handling for attempts to invoke ignored methods. If a method marked with @FeignIgnore is called, the system will now throw an UnsupportedOperationException, improving the robustness of the application.
• Test: Added new test cases to ensure the correct functioning of the @FeignIgnore annotation and the associated error handling mechanism.

[coderabbitai]

Walkthrough

The changes introduce a new annotation @FeignIgnore to the Feign library, allowing methods to be marked for exclusion from processing. If an ignored method is invoked, an UnsupportedOperationException is thrown. Tests have been added to ensure the functionality works as expected.

Changes

File Path	Summary
core/src/main/java/feign/...	Introduced @FeignIgnore annotation and added conditions to skip methods marked with it.
core/src/test/java/feign/FeignTest.java	Added new methods and tests to verify the @FeignIgnore functionality.
reactive/src/main/java/feign/...	Added conditions to throw an exception when an ignored method is invoked.
reactive/src/test/java/feign/...	Updated imports, added new methods and tests for the @FeignIgnore functionality.

🐇💻

In the land of code, where the brackets lie,

A rabbit hopped, with a twinkle in its eye.

With each key press, a new world unfurls,

"Ignore the noise," whispers the bunny, "and watch your code swirls."

A new annotation, a skip and a hop,

With @FeignIgnore, unwanted methods, we stop.

So here's to the changes, may they run without a hitch,

Coding with joy, isn't life a rich! 🎉🥕

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai help to get help.
• @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between bc8b4b1 and df58fc4.

Files selected for processing (3)

• core/src/main/java/feign/Contract.java (1} hunks)
• core/src/main/java/feign/FeignIgnore.java (1} hunks)
• core/src/test/java/feign/FeignTest.java (1} hunks)

Files skipped from review due to trivial changes (2)

• core/src/main/java/feign/Contract.java
• core/src/main/java/feign/FeignIgnore.java

Additional comments: 1

core/src/test/java/feign/FeignTest.java (1)

• 1275-1276: The new @FeignIgnore annotation is being used here to ignore the ignore() method during processing. This change seems to be in line with the PR summary and doesn't appear to introduce any issues. However, ensure that the ignore() method is not being called anywhere in the codebase, as it will not be processed due to the @FeignIgnore annotation.

[velo]

I like the change, and makes lots of sense. But I think it should fire a clear exception if a ignored method is invoked.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between df58fc4 and 799364c.

Files selected for processing (4)

• core/src/main/java/feign/ReflectiveFeign.java (1 hunks)
• core/src/test/java/feign/FeignTest.java (3 hunks)
• reactive/src/main/java/feign/reactive/ReactiveInvocationHandler.java (1 hunks)
• reactive/src/test/java/feign/reactive/ReactiveFeignIntegrationTest.java (4 hunks)

Additional comments: 9

core/src/main/java/feign/ReflectiveFeign.java (1)

• 94-95: The addition of a check for the method in the dispatch map before invoking it is a good practice. It prevents potential NullPointerException if the method is not found in the map. Throwing an UnsupportedOperationException is a reasonable approach to handle such cases. However, ensure that this exception is properly handled in the upstream code to avoid unexpected application crashes.

reactive/src/main/java/feign/reactive/ReactiveInvocationHandler.java (1)

• 51-52: The new code checks if the method is present in the dispatch map and throws an UnsupportedOperationException if it's not. This is a good way to handle methods that are not supposed to be called, but it might be helpful to add a comment explaining why this check is necessary, especially since it's a change in behavior that could potentially break existing code if not handled properly.

reactive/src/test/java/feign/reactive/ReactiveFeignIntegrationTest.java (4)

• 26-28: The import statements have been reorganized and some unused imports have been removed. Ensure that this does not affect other parts of the code that might be using these imports.

• 44-44: The import for org.junit.Assert has been added. This is used for the assertion in the new test method testCallIgnoredMethod.

• 66-78: A new test method testCallIgnoredMethod has been added. This test method creates a TestReactorService instance and tries to call the ignore method, which is annotated with @FeignIgnore. The test expects an UnsupportedOperationException to be thrown when the ignore method is called. This test validates the new @FeignIgnore annotation functionality.

• 344-345: A new method ignore has been added to the TestReactorService interface and is annotated with @FeignIgnore. This method is used in the new test method testCallIgnoredMethod.

core/src/test/java/feign/FeignTest.java (3)

• 36-36: The import org.junit.Assert has been added. Ensure that it is used in the code.

• 1171-1183: A new test method testCallIgnoredMethod has been added. This test method creates an instance of TestInterface and calls the ignore method. It expects an UnsupportedOperationException to be thrown. This test validates the new @FeignIgnore annotation functionality.

• 1290-1292: The ignore method has been added to the TestInterface and is annotated with @FeignIgnore. This method is used in the testCallIgnoredMethod test.