Optimize moshi decoding #2183
Merged
Optimize moshi decoding #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe proposed changes streamline the Moshi decoder in Feign by eliminating unused imports and simplifying JSON parsing. The modifications enhance performance and readability, making the code more efficient and maintainable. Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
velo
reviewed
Sep 26, 2023
| @@ -13,19 +13,16 @@ | |||
| */ | |||
| package feign.moshi; | |||
|
|
|||
| import com.google.common.io.CharStreams; | |||
There was a problem hiding this comment.
Can you also remove the guava dependency from pom?
There was a problem hiding this comment.
Good point, done in f3cd4d8
velo
approved these changes
Sep 30, 2023
1 task
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* perf: avoid writing full body to an intermediate string * fix: eagerly return null for empty bodies * chore(moshi): remove guava dependency --------- Co-authored-by: Marvin Froeder <[email protected]>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* perf: avoid writing full body to an intermediate string * fix: eagerly return null for empty bodies * chore(moshi): remove guava dependency --------- Co-authored-by: Marvin Froeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2182
Summary by CodeRabbit
MoshiDecoderin the Moshi library. The changes include removing unused imports, replacing theReaderwithBufferedSourcefrom Okio for improved performance, and directly parsing JSON usingjsonAdapter.fromJson(). This refactor enhances the efficiency of the decoding process and simplifies the underlying code structure.