Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support method option and add UT #1881
support method option and add UT #1881
Changes from all commits
d786bd3
f71537b
fa7eab5
e3e0e8e
067e247
78cfff3
a7c884c
a9cb3f3
a5486f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new methods
getMethodOptions
andsetMethodOptions
are correctly implemented. However, there is a potential issue with thread safety. ThegetMethodOptions
method retrieves aMap
fromthreadToMethodOptions
and then directly returns anOptions
object from it. If another thread modifies thisMap
in the meantime (viasetMethodOptions
), it could lead to inconsistent states. Consider returning a deep copy of theOptions
object instead of the object itself to avoid this issue.