Skip to content

Conversation

@ColinHDev
Copy link
Member

@ColinHDev ColinHDev commented Apr 29, 2025

Summary of the discussion

As discussed in #1960, the current grid component class should be extended by an equivalence axiom of a new grid component role class.

Type of change (CHANGELOG.md)

Add

  • Added grid component role as a subclass of role
    • definition: A grid component role is a role of an energy transformation unit that is a discrete part of a supply grid serving a specific purpose.

Update

  • Added the equivalence axiom 'energy transformation unit' that 'has role' some 'grid component role' to the grid component class

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Apr 29, 2025
@ColinHDev ColinHDev marked this pull request as draft April 29, 2025 08:33
@ColinHDev ColinHDev requested a review from stap-m April 29, 2025 08:33
@ColinHDev
Copy link
Member Author

This is currently only the basic idea of the change. I haven't updated any definition (apart from the one of grid component role) yet.
Also, grid component had the subclasses (gas | heating | electricity) grid component. The same motivation for the removal of grid component should also apply to them, right?

@stap-m
Copy link
Contributor

stap-m commented Apr 29, 2025

@ColinHDev sorry, for not being clearer: the former class grid component (OEO_00020006) should stay grid component but become an equivalent class 'artificial object' and 'has role' some 'grid component role', where you create grid component role newly. Like this, the concept of the class isn't changed too much, in case it is already being used somewhere.

@ColinHDev
Copy link
Member Author

@ColinHDev sorry, for not being clearer: the former class grid component (OEO_00020006) should stay grid component but become an equivalent class 'artificial object' and 'has role' some 'grid component role', where you create grid component role newly. Like this, the concept of the class isn't changed too much, in case it is already being used somewhere.

So like this?

@stap-m
Copy link
Contributor

stap-m commented May 9, 2025

Yes. Please add to the def of grid compnent a sentence like "It is defined via the grid component role."
Please also update the header to summarize the content of this PR and add term trackers to grid component.

@ColinHDev ColinHDev changed the title Change 'grid component' class to 'grid component role' Add grid component role as equivalence to grid component May 13, 2025
@ColinHDev ColinHDev changed the title Add grid component role as equivalence to grid component Add grid component role May 13, 2025
@ColinHDev ColinHDev marked this pull request as ready for review May 13, 2025 07:54
@ColinHDev
Copy link
Member Author

Yes. Please add to the def of grid compnent a sentence like "It is defined via the grid component role." Please also update the header to summarize the content of this PR and add term trackers to grid component.

Everything should be implemented now.

@stap-m stap-m requested a review from LillyG901 May 13, 2025 12:21
Copy link
Contributor

@LillyG901 LillyG901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks great :)

@ColinHDev ColinHDev merged commit 16ad5ea into dev May 20, 2025
3 checks passed
@ColinHDev ColinHDev deleted the feature-1960-grid_component_role branch May 20, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oeo-physical changes the oeo-physical module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants