Skip to content

Add user perm check on backend when deleting a tag #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add user perm check on backend when deleting a tag #1949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dataedit/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,9 @@ def change_tag(request):
# requested changes are not valid because of name conflicts
status = "invalid"

if not request.user.has_admin_permissions():
raise PermissionDenied

elif "submit_delete" in request.POST:
id = request.POST["tag_id"]
delete_tag(id)
Expand Down