Local UI tidy up #961
Merged
Local UI tidy up #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (1)
- platformio.ini: Language not supported
Comments suppressed due to low confidence (2)
src/screens/screen_charge.cpp:9
- Duplicate inclusion of 'emonesp.h' found; please remove the redundant include to improve code clarity.
#include "emonesp.h"
src/screens/screen_factory.h:10
- [nitpick] Consider changing the 'screenType' parameter type from int to the 'ScreenType' enum for improved type safety and clarity.
static ScreenBase* createScreen(int screenType, TFT_eSPI &screen, EvseManager *evse, Scheduler *scheduler, ManualOverride *manual) {
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break apart of the local UI into separate files to help with maintinance