Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At First trying to make a hardlink from backupfile #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

At First trying to make a hardlink from backupfile #63

wants to merge 2 commits into from

Conversation

dolorosus
Copy link

On small systems (e.g. openelec with 8Gb Micro sim), large Backupfiles can't be restore due to missing space for creating the copy of the backup tarfile in .restore.
Trying first to create a hardlink of the tarfile will avoid this this problem. creating a hardlink is much faster than than copying the tarfile.
If cerating the link results in error, a copy of the tarfile will be created the same way as before .

On small systems like cubox or RasPi a restore of larger backups fails due to missing space caused by making a copy of the tarfile to .restore. Trying to make a hardlink instead of copying the tar file could solve this.
Trying to create a link of the backup tarfile
@stefansaraev
Copy link
Contributor

@lfiebach @sraue you ok with this ?

@dolorosus please remove the merge commit and set some more clear commit msg instead of "update xxx" on the other. thanks.

@stefansaraev
Copy link
Contributor

@dolorosus for some weird stupid reason, LOT of RPi/RPi2 users prefer to have their /storage formatted as fat32 (of couse we dont support that). just fyi, this will break backup/restore for people who do nonsense ;)

@dolorosus
Copy link
Author

No, it won't ;)
Creating hardlinks on fat32 will result in an OSError. This is catched and results in a filecopy as before.

@stefansaraev
Copy link
Contributor

oh. cool.

@stefansaraev
Copy link
Contributor

mind rebasing ? see my first comment,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants