Skip to content

Commit

Permalink
clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
Browse files Browse the repository at this point in the history
The USB and PCIE pipe clocks are sourced from external clocks
inside the QMP USB/PCIE PHYs. Enabling or disabling of PIPE RCG
clocks is dependent on PHY initialization sequence hence
update halt_check to BRANCH_HALT_SKIP for these clocks so
that clock status bit is not polled when enabling or disabling
the clocks. It allows to simplify PHY client driver code which
is both user and source of the pipe_clk and avoid error logging
related status check on clk_disable/enable.

Signed-off-by: Manu Gautam <[email protected]>
Reviewed-by: Douglas Anderson <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
  • Loading branch information
Manu Gautam authored and bebarino committed Jun 1, 2018
1 parent 7d99ced commit 096abdc
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/clk/qcom/gcc-msm8996.c
Original file line number Diff line number Diff line change
Expand Up @@ -1418,6 +1418,7 @@ static struct clk_branch gcc_usb3_phy_aux_clk = {

static struct clk_branch gcc_usb3_phy_pipe_clk = {
.halt_reg = 0x50004,
.halt_check = BRANCH_HALT_SKIP,
.clkr = {
.enable_reg = 0x50004,
.enable_mask = BIT(0),
Expand Down Expand Up @@ -2472,6 +2473,7 @@ static struct clk_branch gcc_pcie_0_aux_clk = {

static struct clk_branch gcc_pcie_0_pipe_clk = {
.halt_reg = 0x6b018,
.halt_check = BRANCH_HALT_SKIP,
.clkr = {
.enable_reg = 0x6b018,
.enable_mask = BIT(0),
Expand Down Expand Up @@ -2547,6 +2549,7 @@ static struct clk_branch gcc_pcie_1_aux_clk = {

static struct clk_branch gcc_pcie_1_pipe_clk = {
.halt_reg = 0x6d018,
.halt_check = BRANCH_HALT_SKIP,
.clkr = {
.enable_reg = 0x6d018,
.enable_mask = BIT(0),
Expand Down Expand Up @@ -2622,6 +2625,7 @@ static struct clk_branch gcc_pcie_2_aux_clk = {

static struct clk_branch gcc_pcie_2_pipe_clk = {
.halt_reg = 0x6e018,
.halt_check = BRANCH_HALT_SKIP,
.clkr = {
.enable_reg = 0x6e018,
.enable_mask = BIT(0),
Expand Down

0 comments on commit 096abdc

Please sign in to comment.