Skip to content

[RFC] Add support for flexcomm14 and 15#235

Closed
DM777-ms wants to merge 1 commit into
OpenDevicePartnership:mainfrom
DM777-ms:fc1415
Closed

[RFC] Add support for flexcomm14 and 15#235
DM777-ms wants to merge 1 commit into
OpenDevicePartnership:mainfrom
DM777-ms:fc1415

Conversation

@DM777-ms
Copy link
Copy Markdown

@DM777-ms DM777-ms commented Dec 6, 2024

Surface project requires flexcomm14 for spi and fc15 for i2c. Adding support for fc14 and 15 with this pr.

Addresses #230

@DM777-ms DM777-ms self-assigned this Dec 6, 2024
@DM777-ms DM777-ms marked this pull request as draft December 6, 2024 21:28
@felipebalbi
Copy link
Copy Markdown
Contributor

looks like this should be a single commit.

@felipebalbi felipebalbi added the enhancement New feature or request label Dec 10, 2024
@felipebalbi felipebalbi linked an issue Dec 10, 2024 that may be closed by this pull request
@DM777-ms DM777-ms mentioned this pull request Dec 12, 2024
Comment thread src/flexcomm.rs Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just add 14 and 15 here? If we only want to enable frg_clk support for 14 and 15, then we can add the macro for 14 and 15 + not change impl_flexcomm!().

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fc14 and fc15 have uniquely named registers that would need to be referenced by impl_flexcomm!(). Still tbd on how to update the macro to incorporate the different register sets for fc0-7, fc14, fc15.

Ex:
clkctl1.fc14fclksel().write(|w| match clk { ... });
clkctl1.frg14clksel().write(|w| match clk { ... });
clkctl1.frg14ctl.write( ... );

clkctl1.fc15fclksel().write(|w| match clk { ... });
clkctl1.frg15clksel().write(|w| match clk { ... });
clkctl1.frg15ctl.write( ... );

Copy link
Copy Markdown
Contributor

@felipebalbi felipebalbi Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's something we can patch in the PACs. It looks like FC14 and FC15 should be added to the flexcomm cluster. Let me give that a try.

UPDATE: it's doable, but I didn't check to make sure all registers are exactly the same.

@tullom tullom self-assigned this Feb 10, 2025
@jerrysxie jerrysxie closed this Feb 28, 2025
@github-project-automation github-project-automation Bot moved this from Ready to Done in ODP Backlog Feb 28, 2025
tullom added a commit that referenced this pull request Mar 18, 2025
- Adding #235
to enable FC14 and FC15
- Changes in I2C module to support FC15 I2C master

@tullom FYI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request for sync

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add support for fc14 and fc15

5 participants