Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fresh_refresh file #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fresh_refresh file #238

wants to merge 1 commit into from

Conversation

KarenJewell
Copy link
Member

@KarenJewell KarenJewell commented Jun 10, 2023

File to create weekly pipeline change summary, dubbed the "fresh refresh"

Description

python file created to summarise the week's dataset changes, the output is intended to be posted to slack, twitter and linkedin.

Motivation and Context

Related to issue #110

How Has This Been Tested?

All runs have been on local environment so far.
To run locally:

  • must have od-bods and jkan repos locally and in the same location.
  • git pull latest jkan
  • in the_od_bods run 'python analytics/fresh_refresh.py'

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@KarenJewell KarenJewell requested a review from JackGilmore June 10, 2023 10:45
# %%
### Load data from all files in folder
org_twitter_all = {}
folder = '../jkan/_organizations'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might find it more reliable to get the org details from https://opendata.scot/organizations.json.

If not, I think this path needs to be changed to ../../jkan/_organizations given that this script is nested within the analytics folder


def get_org_name(filename):
try:
with open(f'../jkan/{filename}','r') as f:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path also needs changed to ../../jkan/{filename}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants