-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate pyuavcan.dsdl generation core to lang/py #234
Conversation
Actually, I need to check a couple things. Feel free to review though. |
This is great. I'll review this tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were there any changes to the Jinja templates?
The most interesting thing I suppose is the test suite. Are you planning to integrate it with the same changeset or should we expect a new one later?
Please run |
You need to add |
Already done, will push after fixing a couple mypy issues. |
This PR is stale. Resubmit to continue with the review. Thanks. |
This changeset also drops support for Python 3.6. Fixes OpenCyphal/pycyphal#110 Required for OpenCyphal/pycyphal#277 Supersedes #234
I patched the nunavut core to support (recursive) directories in the support directory, but then ended up consolidating all the python support code into a single file
nunavut_support.py
. Leaving this here in case it comes in handy in the future, it doesn't add any notable complexity. LMK if it should be removed.Pyuavcan PR coming up in a minute.