Skip to content

fix(media-overlay): add cursor-pointer when clickable #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(media-overlay): add cursor-pointer when clickable #583

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bd67e8
fix(media-overlay): add cursor-pointer when clickable
iyiolacak Aug 31, 2025
b3fd01b
fix(media-overlay): add cursor-pointer when clickable, use cn, and im…
iyiolacak Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/web/src/components/editor/media-panel/drag-overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Upload, Plus, Image } from "lucide-react";
import { Upload } from "lucide-react";
import { Button } from "@/components/ui/button";

interface MediaDragOverlayProps {
Expand Down Expand Up @@ -27,7 +27,10 @@ export function MediaDragOverlay({

return (
<div
className="flex flex-col items-center justify-center gap-4 h-full text-center rounded-lg bg-foreground/5 hover:bg-foreground/10 transition-all duration-200 p-8"
className={[
"flex flex-col items-center justify-center gap-4 h-full text-center rounded-lg bg-foreground/5 hover:bg-foreground/10 transition-all duration-200 p-8",
!isProcessing && onClick ? "cursor-pointer" : "cursor-default"
].join(" ")}
onClick={handleClick}
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Don't attach handlers when not interactive.

Attaching onClick to a non-interactive element violates our JSX guideline. Only bind the handler when clickable.

-      onClick={handleClick}
+      onClick={isClickable ? handleClick : undefined}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
onClick={handleClick}
onClick={isClickable ? handleClick : undefined}
🤖 Prompt for AI Agents 
In apps/web/src/components/editor/media-panel/drag-overlay.tsx around line 37,
the JSX currently attaches onClick={handleClick} unconditionally; update the
component so event handlers are only bound when the element is actually
interactive: either conditionally include the onClick prop (e.g. spread an
interactiveProps object only when clickable/interactive is true) or convert the
element to a semantic interactive element (button) and add appropriate
accessibility attributes (role, tabIndex, aria-*) if it must remain a non-button
but interactive; ensure no onClick is attached when the overlay is
non-interactive.

>
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Use a semantic button instead of a div for clickability (a11y + guidelines).

Current pattern attaches onClick to a non-interactive element, which violates the project guideline “Don’t use event handlers on non-interactive elements” and misses keyboard activation by default. Replace the root with a (with type and disabled), which also removes the need for extra key handlers.

-    <div
+    <button
+      type="button"
+      disabled={isProcessing || !onClick}
       className={[
         "flex flex-col items-center justify-center gap-4 h-full text-center rounded-lg bg-foreground/5 hover:bg-foreground/10 transition-all duration-200 p-8",
         !isProcessing && onClick ? "cursor-pointer" : "cursor-default"
       ].join(" ")}
       onClick={handleClick}
-    >
+    >
...
-    </div>
+    </button>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div
className="flex flex-col items-center justify-center gap-4 h-full text-center rounded-lg bg-foreground/5 hover:bg-foreground/10 transition-all duration-200 p-8"
className={[
"flex flex-col items-center justify-center gap-4 h-full text-center rounded-lg bg-foreground/5 hover:bg-foreground/10 transition-all duration-200 p-8",
!isProcessing && onClick ? "cursor-pointer" : "cursor-default"
].join(" ")}
onClick={handleClick}
>
<button
type="button"
disabled={isProcessing || !onClick}
className={[
"flex flex-col items-center justify-center gap-4 h-full text-center rounded-lg bg-foreground/5 hover:bg-foreground/10 transition-all duration-200 p-8",
!isProcessing && onClick ? "cursor-pointer" : "cursor-default"
].join(" ")}
onClick={handleClick}
>
{/* …existing children/content… */}
</button>

<div className="flex items-center justify-center">
Expand Down