Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

.net core support #595

Closed
sawilde opened this issue Jun 3, 2016 · 15 comments
Closed

.net core support #595

sawilde opened this issue Jun 3, 2016 · 15 comments
Assignees

Comments

@sawilde
Copy link
Member

sawilde commented Jun 3, 2016

https://github.com/dotnet/corefx/issues/8880

@sawilde, does OpenCover have a hard dependency on mscorlib.dll being named "mscorlib"? The core library has been renamed for .NET Core from "mscorlib" to "System.Private.Corelib", and I'm wondering if that change explains why OpenCover is reporting 0 hits on everything.

So we need to add hooks for that assembly name in CuckooSupportCompilation.

@sawilde
Copy link
Member Author

sawilde commented Jun 6, 2016

They are currently using the -oldstyle switch - which seems to be working for them

@joemcbride
Copy link

Question on this - is the .NET Core support going to be only Windows, or also support macOS, Linux, etc.? Thanks!

@sawilde
Copy link
Member Author

sawilde commented Apr 20, 2017

@joemcbride currently it is windows only because we rely on the profiling API which is COM based (an ancient technology in modern IT terms that I cut my teeth on in my youth).

There is this thread on the .net core clr repo regarding the Profiling API that I am keeping my eye on but until they release it xplat (the release keeps shifting) I am unable to do anything with that.

@joemcbride
Copy link

Drats, well here's to hoping. Thanks!

@JSkimming
Copy link

an ancient technology in modern IT terms that I cut my teeth on in my youth

@sawilde Stop it, you're making me nostalgic for those days back in Henley-on-Thames 😃

@sawilde
Copy link
Member Author

sawilde commented Jan 3, 2018

@psibernetic I have been looking at it - the windows one took months of part-time development - so don't expect anything soon - it isn't a simple port.

@jp7677
Copy link

jp7677 commented Jan 27, 2018

Hi there. I'm using an appveyor build of OpenCover with a Mono.Cecil beta that works pretty well for Netcore (C# and F#) with portable debug symbols. I can fully understand though that you prefer to wait for a final release of Mono.Cecil before doing a release for OpenCover again. That said I'm not sure anymore that Mono.Cecil will ever come out of beta. Is there an alternative in that case?

@sawilde
Copy link
Member Author

sawilde commented Mar 6, 2018

@jp7677 I don't have one as yet - I've been looking at starting again using the new profiler APIs that come with .net core but I just don't have the time at the moment.

@sharwell
Copy link

sharwell commented Mar 19, 2018

@sawilde Mono.Cecil 0.10 was just released with support for portable PDB formats. 😄 Do you know if the next release will support only portable PDB files on disk, or also support portable PDBs that are embedded in the binary?

@danmoseley
Copy link

In the .NET Core repos, we are eager to move to an OpenCover that supported portable PDB

@sawilde
Copy link
Member Author

sawilde commented Mar 21, 2018

YES! I've sort of stopped looking!

@sharwell hopefully both - though I may need to tinker with how I use mono.cecil - got easter break coming up so will hopefully find a few days over that period - pray for rainy weather!

@danmoseley
Copy link

Any luck over Easter @sawilde ?

@sawilde
Copy link
Member Author

sawilde commented Jan 2, 2021

We can handle .net core but the support has been patchy with what looks like the PDBs changing format.

Portable and Embedded works with .net 2.2 using the -oldstyle switch - I suspect this is because the Cuckoos aren't loading

@sawilde
Copy link
Member Author

sawilde commented Jan 10, 2021

We get coverage from .net core 2.2 and .net core 3.1 using the -oldstyle switch and .net 5.0 with or without that switch

Try the release candidate 4.7.1137-rc or a later build

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants