Docker: Create a parameters.yaml.dist that works in a docker dev env #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartje
changed the title
quartje
force-pushed
the
feature/docker_configs
branch
from
e2a8f61 to
5cac999
Compare
MKodde
force-pushed
the
feature/docker_configs
branch
from
36edbf6 to
25c9679
Compare
This will let the logs go to stdout when running as a container, which is the Docker way to send logs
MKodde
reviewed
Sep 6, 2023
config/legacy/parameters.yaml.dist
Outdated
| self_service_email_verification_url_template: https://selfservice.tld/verify-email?n={nonce} | ||
| email_sender_name: SURFnet bv | ||
| email_sender_email: [email protected] | ||
| self_service_email_verification_url_template: https://sa.dev.openconext.local/verify-email?n={nonce} |
There was a problem hiding this comment.
Shouldn't this be: selfservice.dev.openconext.local ?
MKodde
requested changes
Sep 6, 2023
config/legacy/parameters.yaml.dist
Outdated
|
|
||
| self_service_url: https://selfservice.tld | ||
| self_service_url: https://sa.dev.openconext.local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the larger project where we aim to build docker containers of all Stepup apps. All the application .dist files are modified so they will, when instantiated, out of the box with the other docker containers (with a docker-compose file that can be found here: https://github.com/OpenConext/OpenConext-devconf/blob/main/stepup/docker-compose.yml