Institution configuration options read-side #145
Conversation
arothuis
changed the title
| public $institution; | ||
|
|
||
| /** | ||
| * @ORM\Column(type="boolean") |
There was a problem hiding this comment.
no doctrine types? Not saying you must introduce them, but if not it would deviate from the "normal" way afaik, thus that should be documented.
There was a problem hiding this comment.
Yes, I want these to be Doctrine types. I want it to return VOs or it's going to be too inconsistent for comfort.
|
Might want to quickly introduce doctrine types for the VO's (also makes changes in the VO's format easier btw). But whatever you decide (docs or doctrine types), 👍 as it stands. |
|
|
||
| public function getSQLDeclaration(array $fieldDeclaration, AbstractPlatform $platform) | ||
| { | ||
| return $platform->getVarcharTypeDeclarationSQL($fieldDeclaration); |
There was a problem hiding this comment.
This probably should not be a Varchar... ;)
|
@DRvanR; the options have been replaced with custom types and a migration has been added. Sadly, the migration has accidentally been removed. I'm might rebase the specific commit just this once to keep a clean commit history. |
|
sure thing, 👍 |
arothuis
force-pushed
the
feature/institution-configuration-options-read
branch
from
754c47c to
cf1d35c
Compare
This adds the read side of the institution configuration options: repository, entity and projector.