Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable networkmanager #64

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dnmvisser
Copy link
Contributor

Fixes #63

@pmeulen
Copy link
Member

pmeulen commented May 7, 2018

Hi dnmvisser,

Thanks for your contribution!

First a remark over form: could you please only add the commit(s) that contributes to the feature (i.e. 09fc9a3) to this PR, and not include the other, unrelated, commits? This way it is unclear what will be merged. You could remake your PR and force push the new one (unlike what https://help.github.com/articles/about-pull-requests/ says, doing a force push will work fine in my experience). You could also start a new PR, and close this one.

Regarding the implementation:

  • Adding the option to NOT disable the NetworkManager is fine. I think disable_networkmanager would better describe what it does.
  • You specify the variable as a boolean, which makes sense IMO. In that case the default() filter is a better fit (i.e. when: disable_networkmanager | default(true)) because then defining the variable with either true or false works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants