Make Behat tests Symfony 4 proof #130
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, when the build is not in development mode, the production debug=false option is used. When in dev mode, debug mode is engaged, and a conditional smoketest env can be set if the testcookie was present. Should be fine for production releases as they will not be polluted with the additional config. To pull this change run: './deploy-site-app.sh' Should be rather compatible with the Stepup RV changes found here: https://github.com/OpenConext/Stepup-Deploy/blob/572d09b8dc068710af3f39dcaccbca627293a9f7/roles/app/templates/php72-nginx-vhost-symfony4.conf.j2#L45-L51
app/console was used throughout this Context. This resulted in failing behat tests.
MKodde
requested review from
phavekes,
pmeulen and
pablothedude
and removed request for
phavekes
pablothedude
reviewed
Mar 4, 2021
| } | ||
| {% endif %} | ||
|
|
||
| fastcgi_param SYMFONY_ENV $app_env; |
There was a problem hiding this comment.
I would opt to hardcode this for production
phavekes
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes are required to get the Behat tests to work again
bin/console, notapp/console