Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix global search toolbar (#8837) #8845

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[frontend] Fix global search toolbar (#8837) #8845

merged 1 commit into from
Oct 31, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Oct 31, 2024

Proposed changes

  • add globalSearch param to dataTable (searchTerm is not saved in local storage for global search)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Before the fix: Search term is not present in the scope (screenshot from testing platform)
Capture d'écran 2024-10-31 113845

After the fix: Search term is present in the scope (screenshot from local platform with bug fix)
image

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 31, 2024
@SouadHadjiat SouadHadjiat linked an issue Oct 31, 2024 that may be closed by this pull request
@SouadHadjiat SouadHadjiat marked this pull request as ready for review October 31, 2024 10:29
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (11067c2) to head (914a4e4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8845   +/-   ##
=======================================
  Coverage   66.29%   66.30%           
=======================================
  Files         597      597           
  Lines       60976    60976           
  Branches     6266     6266           
=======================================
+ Hits        40427    40430    +3     
+ Misses      20549    20546    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@labo-flg labo-flg merged commit 0eea615 into master Oct 31, 2024
6 checks passed
@labo-flg labo-flg deleted the issue/8837 branch October 31, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug may lead to deletion of all entities in OpenCTI
3 participants