Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Display the title in widgetText #8841

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[frontend] Display the title in widgetText #8841

merged 1 commit into from
Nov 4, 2024

Conversation

CelineSebe
Copy link
Member

@CelineSebe CelineSebe commented Oct 31, 2024

Proposed changes

  • add props

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@CelineSebe CelineSebe self-assigned this Oct 31, 2024
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 31, 2024
@CelineSebe CelineSebe linked an issue Oct 31, 2024 that may be closed by this pull request
@CelineSebe CelineSebe changed the title [frontend] Fix title within widgetText [frontend] Display the title in widgetText Oct 31, 2024
@CelineSebe CelineSebe marked this pull request as ready for review October 31, 2024 08:52
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.30%. Comparing base (11067c2) to head (0bc62ce).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8841   +/-   ##
=======================================
  Coverage   66.29%   66.30%           
=======================================
  Files         597      597           
  Lines       60976    60976           
  Branches     6266     6265    -1     
=======================================
+ Hits        40427    40428    +1     
+ Misses      20549    20548    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact self-requested a review November 4, 2024 08:39
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ok 👌

@CelineSebe CelineSebe merged commit 13078ec into master Nov 4, 2024
6 checks passed
@CelineSebe CelineSebe deleted the issue/8560 branch November 4, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title not taken into account in Text widget
2 participants