Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] redirect link updated for observables (#8483) #8695

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ValentinBouzinFiligran
Copy link
Member

Proposed changes

  • in case of observable, the redirect link will send you on the overview page

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.40%. Comparing base (dae148d) to head (09fd056).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8695      +/-   ##
==========================================
+ Coverage   66.07%   66.40%   +0.32%     
==========================================
  Files         597      597              
  Lines       60913    60944      +31     
  Branches     6204     6273      +69     
==========================================
+ Hits        40246    40467     +221     
+ Misses      20667    20477     -190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn self-requested a review October 21, 2024 07:39
@ValentinBouzinFiligran ValentinBouzinFiligran linked an issue Oct 21, 2024 that may be closed by this pull request
@ValentinBouzinFiligran ValentinBouzinFiligran merged commit e4f361a into master Oct 21, 2024
6 checks passed
@ValentinBouzinFiligran ValentinBouzinFiligran deleted the issue/8483 branch October 21, 2024 07:56
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title redirect link updated for observables [frontend] redirect link updated for observables (#8483) Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sightings tabs in observables are broken
2 participants