Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide some actions in "data" tab when user does not have the capability to create/update knowledge #8243

Closed
romain-filigran opened this issue Sep 4, 2024 · 3 comments · Fixed by #9313
Closed

Hide some actions in "data" tab when user does not have the capability to create/update knowledge #8243

romain-filigran opened this issue Sep 4, 2024 · 3 comments · Fixed by #9313
Assignees
@Archidoit
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) ui for scope limited to UI change
Milestone
Release 6.4.5

Comments

@romain-filigran
Copy link
Member

romain-filigran commented Sep 4, 2024 •
edited
Loading

Description

Hide all action buttons in "Data" tab related to creation or modification of knowledge if the user does not have the capability to create/update knowledge.

Capture d'écran 2024-09-04 095204

Environment

  1. OpenCTI version: 6.2.18
@romain-filigran romain-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team ui for scope limited to UI change and removed needs triage use to identify issue needing triage from Filigran Product team labels Sep 4, 2024
@romain-filigran romain-filigran added this to the Bugs backlog milestone Sep 4, 2024
@romain-filigran romain-filigran changed the title Hide some actions in "data" tab when user hasn't the capability to create/update knowledge Hide some actions in "data" tab when user does not have the capability to create/update knowledge Sep 4, 2024
@Archidoit Archidoit self-assigned this Sep 5, 2024
@Archidoit Archidoit modified the milestones: Bugs backlog, Release 6.3.0 Sep 5, 2024
@Archidoit
Copy link
Member

Archidoit commented Sep 5, 2024 •
edited
Loading

other bug : You can create a workbench in an entity even if you don't have the Knowledge update capability

@Archidoit
Copy link
Member

Archidoit commented Dec 11, 2024 •
edited
Loading

@nino-filigran @romain-filigran do we know what we want?

  • to be able to upload a file in Data>entities: capa update knowledge + upload knowledge
  • to be able to delete a file in Data>entities: capa import knowledge
  • to be able to delete a workbench: capa import knowledge
  • to be able to create a workbench: capa import knowledge

(see table in Notion page)

@nino-filigran
Copy link

To be clear, based on @Archidoit last's comment, we'll use the current capabilities as is to present or not the CTAs. This means:

  • CTA upload & "tt" present only if user has update knowledge & upload knowledge
  • CTA create worbench present only if user has import knowledge
  • CTA delete file only if user has import knowledge

Changing the capabilities might cause lots of unwanted effects.

@Archidoit Archidoit modified the milestones: Bugs backlog, Release 6.4.4 Dec 11, 2024
@labo-flg labo-flg modified the milestones: Release 6.4.4, Release 6.4.5 Dec 11, 2024
Archidoit added a commit that referenced this issue Dec 12, 2024
@Archidoit
[frontend] Hide actions in Data tab according to capability (#8243)
e8033b0
Archidoit added a commit that referenced this issue Dec 12, 2024
@Archidoit
[frontend] Hide actions in Data tab according to capability (#8243)
0d9bdb8
Archidoit added a commit that referenced this issue Dec 12, 2024
@Archidoit
[frontend] Hide actions in Data tab according to capability (#8243)
bd11a74
@Archidoit Archidoit mentioned this issue Dec 12, 2024
Merged
@Archidoit Archidoit linked a pull request Dec 12, 2024 that will close this issue
[frontend] Hide actions in Data tab according to capability (#8243) #9313
Merged
Archidoit added a commit that referenced this issue Dec 13, 2024
@Archidoit
[frontend] Hide actions in Data tab according to capability (#8243)
45bc129
Archidoit added a commit that referenced this issue Dec 13, 2024
@Archidoit
[frontend] Hide actions in Data tab according to capability (#8243)
8df883e
Archidoit added a commit that referenced this issue Dec 13, 2024
@Archidoit
[frontend] Hide actions in Data tab according to capability (#8243)
9b0c7a4
Archidoit added a commit that referenced this issue Dec 13, 2024
@Archidoit
[frontend] Hide actions in Data tab according to capability (#8243)
76ad66f
@Archidoit Archidoit added the solved use to identify issue that has been solved (must be linked to the solving PR) label Dec 13, 2024
@Archidoit Archidoit mentioned this issue Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Archidoit Archidoit

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) ui for scope limited to UI change
Projects
None yet
Milestone
Release 6.4.5
Development

Successfully merging a pull request may close this issue.

[frontend] Hide actions in Data tab according to capability (#8243) OpenCTI-Platform/opencti
4 participants
@Archidoit @labo-flg @nino-filigran @romain-filigran