Skip to content

Support PHP 7.2 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2018
Merged

Support PHP 7.2 #30

merged 3 commits into from
Apr 9, 2018

Conversation

@hkdobrev
Copy link
Contributor

@hkdobrev hkdobrev commented Apr 5, 2018 •
edited
Loading

Implements #23.

@hkdobrev hkdobrev self-assigned this Apr 5, 2018
@hkdobrev hkdobrev requested a review from nclsHart April 5, 2018 12:10
@hkdobrev hkdobrev changed the title 0.6.0 Support PHP 7.2 Apr 5, 2018
@hkdobrev hkdobrev added this to the 0.6.0 milestone Apr 5, 2018
@hkdobrev
Copy link
Contributor Author

hkdobrev commented Apr 9, 2018

I've changed config to test PHP 7.2 only on latest PHPUnit until we support PHP 5.

@hkdobrev hkdobrev modified the milestones: 0.6.0, 0.5.x Apr 9, 2018
nclsHart
nclsHart approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@nclsHart nclsHart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkdobrev hkdobrev merged commit 89b0ce8 into master Apr 9, 2018
@hkdobrev hkdobrev deleted the php-72 branch April 9, 2018 22:09
@hkdobrev hkdobrev mentioned this pull request Apr 9, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nclsHart nclsHart nclsHart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hkdobrev hkdobrev

Labels

None yet

Projects

None yet

Milestone

0.5.x

Development

Successfully merging this pull request may close these issues.

3 participants

@hkdobrev @nclsHart