Remove EOL php versions #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nclsHart Thanks! 🙌 Could you please rebase that on top of latest master as I've merged your other PRs? |
Contributor
|
I've added you as a collaborator to the project 🎉 Please use PRs and let's discuss releases and upgrades in issues for now :) Cheers! |
nclsHart
force-pushed
the
remove-unsupported-versions
branch
from
8589209 to
90fc93e
Compare
Contributor
|
BTW I'm fine with dropping PHP 5 altogether and adding PHP 7.2. |
Contributor
Author
|
@hkdobrev Thanks for the invitation :). My idea was to have something like the following releases: 0.5
This is the current state of master. 0.6
0.7 or 1.0.0
What do you think about it? Maybe we could discuss this in a dedicated issue. |
nclsHart
force-pushed
the
remove-unsupported-versions
branch
from
90fc93e to
737c678
Compare
nclsHart
changed the title
Contributor
|
OK, let's do that! However, tests are failing for me locally. Opened a separate issue for that: #21. |
nclsHart
force-pushed
the
remove-unsupported-versions
branch
from
737c678 to
a7b4cd0
Compare
Contributor
|
Could you please rebase on top of latest master to resolve conflicts? Thanks! |
nclsHart
force-pushed
the
remove-unsupported-versions
branch
from
a7b4cd0 to
67e3e20
Compare
Contributor
Author
|
As discuss in #28, I'll split this in two PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be rebased and merged after #18.
This is a mandatory step before upgrading swiftmailer to 6.x, which require php >= 7.0.0.
Implements #28.