Improve Android responsiveness and message delivery reliability - #225
Closed
Xare123 wants to merge 33 commits into
Closed
Improve Android responsiveness and message delivery reliability#225Xare123 wants to merge 33 commits into
Xare123 wants to merge 33 commits into
Conversation
Author
|
Closing this in favor of three focused PRs. This one had grown to 72 files across seven unrelated themes, which is more than anyone should be asked to review in one pass. Split into:
Each is independent, does not touch the Four things from this PR are deliberately not in the split, because they did not belong under a responsiveness and delivery title:
All four are still on my fork and I am happy to open any of them separately if they are wanted. Just say which. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All done was because my wife agreed to let me switch to android if she didn't lose the blue texts. Found the application not snappy on the Pixel 10 Pro as I hoped at first. Changes done has brought the application to life for me, hope they do for all.
Summary
This branch improves Android responsiveness and message-delivery reliability, while hardening group-chat, reply-thread, and profile/contact handling.
Behavior before and after
These are mechanism-level changes, each verifiable from the diff. They are described as behavior, not as benchmarked speedups.
queue()started a second processor wheneveritems.isEmpty && item is IncomingItem, so two runners could interleave on a burst of incoming messages_runnerActiveguard owns the drain loop;prepItemfailures complete the item's completer with the error instead of stranding itupdateObxwas alate finalcallback re-initialized when a widget was recycled, throwingLateErrorand rendering a gray error block instead of the messageValidation
6028e16: run 30159127049, building Alpha Profile and Debug APKs against the upstream-ready dependency chain.LateErrorrender failures while scrolling a long transcript; the same device and same build type after the fix produced zeroLateError, zero queue failures, and zero reconnect failures during startup and transcript scroll.Measurements, and their limits
The following were measured on the branch build only. There is no matching profile-mode build of the base branch, so these are single-arm observations and should not be read as a measured speedup:
An earlier comparison against the Play Store release is deliberately not quoted here, because it compared a Flutter debug build to a release build and is not a valid control.
Known gaps
SetLoggerErroris logged during startup; initialization still completes and the app remains active.Scope
This PR does not change the Apple validation protocol or claim support for unsupported iOS/macOS configurations. It is intended to be reviewed alongside the two dependency PRs above.