-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boulder grades are not case sensitive #177
Comments
This is good for font grades too, but are there any other boulder grading
systems which are not uppercase?
…On Thu, Nov 7, 2024, 08:13 Julian Lam ***@***.***> wrote:
image.png (view on web)
<https://github.com/user-attachments/assets/38d2fc51-e3c0-4dfe-863f-daecaa2e49a6>
—
Reply to this email directly, view it on GitHub
<#177>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD7ET7FI4DFU3OOVCZ4V2CDZ7OGSDAVCNFSM6AAAAABRLSD7F6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGY2DANJUGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@musoke I don't know of a case-sensitive grading pattern, but I have a similar concern - Luckily this is the sort of front end change that is quick to roll back if someone points out to us the folly of our actions |
French sport and boulder grades are conventionally case-sensitive - often
the case is the only way of distinguishing them. Uppercase for boulder,
lower case for sport.
…On Thu, Nov 7, 2024, 11:16 Colin Gale ***@***.***> wrote:
@musoke <https://github.com/musoke> I don't know of a case-sensitive
grading pattern, but I have a similar concern - Luckily this is the sort of
front end change that is quick to roll back if someone points out to us the
folly of our actions
—
Reply to this email directly, view it on GitHub
<#177>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD7ET7EXIW7ZK74JVYZ56MTZ7O375AVCNFSM6AAAAABRLSD7F6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRTGAZDOMBWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Good to know the context of other systems. It does seem like if it's a boulder one could just uppercase it client side? |
I think in that case this issue should be transferred over to sandbag, since grade formatting standardization should happen there - in the mean time probably best not to do any heuristic casing since it could confuse future devs |
.toUpperCase
required on boulder grades so entries where the grade is enteredv3
will showV3
in front-end.The text was updated successfully, but these errors were encountered: