Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boulder grades are not case sensitive #177

Open
julianlam opened this issue Nov 7, 2024 · 6 comments
Open

Boulder grades are not case sensitive #177

julianlam opened this issue Nov 7, 2024 · 6 comments

Comments

@julianlam
Copy link

.toUpperCase required on boulder grades so entries where the grade is entered v3 will show V3 in front-end.

@julianlam
Copy link
Author

image

@musoke
Copy link
Collaborator

musoke commented Nov 7, 2024 via email

@CocoisBuggy
Copy link

@musoke I don't know of a case-sensitive grading pattern, but I have a similar concern - Luckily this is the sort of front end change that is quick to roll back if someone points out to us the folly of our actions

@musoke
Copy link
Collaborator

musoke commented Nov 7, 2024 via email

@julianlam
Copy link
Author

Good to know the context of other systems.

It does seem like if it's a boulder one could just uppercase it client side?

@CocoisBuggy
Copy link

I think in that case this issue should be transferred over to sandbag, since grade formatting standardization should happen there - in the mean time probably best not to do any heuristic casing since it could confuse future devs

@CocoisBuggy CocoisBuggy transferred this issue from OpenBeta/open-tacos Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants