Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate climb page to Next 13 structure #1195

Merged
merged 8 commits into from
Nov 1, 2024
Merged

Migrate climb page to Next 13 structure #1195

merged 8 commits into from
Nov 1, 2024

Conversation

vnugent
Copy link
Contributor

@vnugent vnugent commented Oct 31, 2024 •
edited
Loading

What type of PR is this?(check all applicable)

  • refactor
  • feature
  • bug fix
  • documentation
  • optimization
  • other

Description

Related Issues

Issue #1077

What this PR achieves

  • Migrate climb page to Next 13 app dir
  • Update getClimbById() GQL query to also fetch sibling climbs (remove extra query)
  • Reuse Area page container for consistent layout
  • Enable photo upload
  • Globally resolve to new page /climb/<id>
  • A crag maps link to top nav

TBD in follow up PRs

  • Page metadata
  • New climb edit page
  • Missing maps link on smaller screens
  • Page alert wrapping issue on smaller screens

Screenshots, recordings

Screenshot 2024-10-31 at 10 39 41 PM

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Nov 1, 2024 5:23am

@vnugent
show grade
8c6cd91 
disable buttnon animation
@vnugent
resolve to /climb page globally
3215b3e 
add map link to main nav
@vnugent vnugent changed the title wip: migrate climb page to next13 structure Migrate climb page to next 13 structure Nov 1, 2024
@vnugent vnugent changed the title Migrate climb page to next 13 structure Migrate climb page to Next 13 structure Nov 1, 2024
@vnugent vnugent merged commit 62e326a into develop Nov 1, 2024
8 of 10 checks passed
@vnugent vnugent deleted the chore-1077 branch November 1, 2024 05:47
@clintonlunn clintonlunn mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vnugent