Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix openbb-yfinance for equity.discovery Functions #6945

Merged
merged 5 commits into from
Nov 16, 2024
Merged

[BugFix] Fix openbb-yfinance for equity.discovery Functions #6945

merged 5 commits into from
Nov 16, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

  2. What?:

    • The current implementation no longer works, revamped to tap into the API.

  3. Impact:

    • Adds a limit parameter.
    • Returns more data, and more fields than previously.

  4. Testing Done:

    • Updates integration and unit tests.

Screenshot 2024-11-13 at 6 28 59 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Nov 14, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Nov 16, 2024
Merged via the queue into develop with commit 79b1e47 Nov 16, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-yfinance-discovery branch December 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Yahoo functions broken in obb.equity.discovery
2 participants
@deeleeramone @IgorWounds