Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] CLI: /technical/sma --chart #6594

Merged
merged 3 commits into from
Jul 19, 2024
Merged

[BugFix] CLI: /technical/sma --chart #6594

merged 3 commits into from
Jul 19, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Fixes error where the item in to_dataframe was not making it passed the intended check.

    • obb.technical.sma(chart=True) works, but CLI encounters a ValueError.

  2. What?:

    • Assign checked value as None and let pass.

  3. Impact:

    • Back to working in CLI.

  4. Testing Done:

    • /equity/price/historical --symbol TSLA --start_date 2024-01-01 --provider yfinance
    • /technical/sma --data OBB0 --chart

@deeleeramone deeleeramone added bug Fix bug v4 PRs for v4 cli OpenBB Platform CLI labels Jul 18, 2024
@deeleeramone deeleeramone requested a review from IgorWounds July 18, 2024 22:25
@github-actions github-actions bot added platform OpenBB Platform labels Jul 18, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Jul 19, 2024
Merged via the queue into develop with commit b588309 Jul 19, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/handle-cli-exception branch July 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug cli OpenBB Platform CLI platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds