Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Update openbb-charting With Numpy Dependency. #6562

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[BugFix] Update openbb-charting With Numpy Dependency. #6562

merged 2 commits into from
Jul 3, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Jul 3, 2024 •
edited
Loading

  1. Why?:

    • openbb-charting and/or openbb-quantitative, when not installed along with openbb-technical, will use Numpy 2.0 which causes import failure from broken syntax in pandas_ta.

  2. What?:

    • Add a version 1 pin to pyproject.toml and update .lock

  3. Impact:

    • The Platform will be able to successfully import.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jul 3, 2024
@deeleeramone deeleeramone requested a review from IgorWounds July 3, 2024 17:00
@IgorWounds IgorWounds added this pull request to the merge queue Jul 3, 2024
Merged via the queue into develop with commit 0bd6cd0 Jul 3, 2024
13 of 14 checks passed
@IgorWounds IgorWounds deleted the bugfix/charting-numpy-version branch July 3, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deeleeramone @IgorWounds